Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Order-Dependent Brittle Tests (OD-Brit) #4

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

zhihao11ui
Copy link

Ran pytest --maxfail=1 --reruns 3 and noticed QueueNotConnectedError from

  • test_mock_queue_unique
  • test_mock_queue_put_get
  • test_mock_queue_get_put_same_task

These tests were found to be flaky, causing error when the Queue was not connected.

The solution is to explicitly connect the Queues, and clear the queue at the beginning to prevent any leftover tasks from influencing the test outcome.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant