Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

luarocks: release version v1.0 . #24

Merged
merged 8 commits into from
Sep 19, 2020
Merged

luarocks: release version v1.0 . #24

merged 8 commits into from
Sep 19, 2020

Conversation

membphis
Copy link
Contributor

@membphis membphis commented Sep 18, 2020

fix #23

@membphis
Copy link
Contributor Author

name lua-resty-hmac has been used in luarocks, so I change the name to lua-resty-hmac-ffi .

Copy link
Owner

@jkeys089 jkeys089 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@membphis thanks for your contribution! I'm on board with the idea but I'm not a luarocks user so I don't know much about their ecosystem. I've reviewed your PR and I had a few questions before proceeding with luarocks distribution.

rockspec/lua-resty-hmac-ffi-1.0-0.rockspec Outdated Show resolved Hide resolved
rockspec/lua-resty-hmac-ffi-1.0-0.rockspec Outdated Show resolved Hide resolved
rockspec/lua-resty-hmac-ffi-1.0-0.rockspec Outdated Show resolved Hide resolved
rockspec/lua-resty-hmac-ffi-1.0-0.rockspec Outdated Show resolved Hide resolved
rockspec/lua-resty-hmac-ffi-1.0-0.rockspec Outdated Show resolved Hide resolved
rockspec/lua-resty-hmac-ffi-1.0-0.rockspec Outdated Show resolved Hide resolved
@membphis
Copy link
Contributor Author

@jkeys089 I have updated the version to 0.05, then you can create a tag with name v0.05.

then we can make a try if it can works fine.

@membphis
Copy link
Contributor Author

I'm on board with the idea but I'm not a luarocks user so I don't know much about their ecosystem

you can sign in at luarocks.org, and upload the file rockspec/lua-resty-hmac-ffi-1.0-0.rockspec to luarocks, then it should work fine.

https://luarocks.org/modules/membphis/lua-resty-hmac-ffi

I upload with my account for testing, it works fine. The use can get it by command luarocks install lua-resty-hmac-ffi.

@jkeys089 jkeys089 merged commit d3c44a0 into jkeys089:master Sep 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: release version on Luarocks.org
2 participants