Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Would you consider replacing mauricio driver which is not supported anymore #91

Closed
oshai opened this issue Jan 11, 2019 · 11 comments
Closed
Milestone

Comments

@oshai
Copy link

oshai commented Jan 11, 2019

We are supporting a fork called jasync-sql that is also used by vertex: https://github.com/vert-x3/vertx-mysql-postgresql-client.
Will you consider adding it or replacing mauricio driver? It is mostly compatible with the following changes: https://github.com/jasync-sql/jasync-sql/wiki/Mauricio-Driver-Migration

@oshai
Copy link
Author

oshai commented Jan 11, 2019

I can provide a PR if you would like that.

@jklingsporn
Copy link
Owner

Hello and thank you for your request. Indeed I was just looking into transaction support for vertx-jooq and how it was implemented in mauricio's driver and then figured out that the project is no longer maintained.
On the other hand it is still part of the official vertx-stack which vertx-jooq is also using.
I can imagine vertx community will drop support for the async driver in vertx 4 but until then I'm afraid I will stick to mauricio's driver.

@oshai
Copy link
Author

oshai commented Jan 11, 2019

As you can see from the link I sent above it is being replaced by jasync. Probably since 3.6.3 was not released yet they did not update that site.

@jklingsporn
Copy link
Owner

Ah, didn't see that. I will switch the implementation then!

@oshai
Copy link
Author

oshai commented Jan 11, 2019

Great!

@jklingsporn jklingsporn added this to the 4.1.0 milestone Jan 11, 2019
@jklingsporn
Copy link
Owner

Unfortunately the driver didn't made it into vertx 3.6.3 so this update has to be postponed.

@jklingsporn jklingsporn removed this from the 4.1.0 milestone Feb 5, 2019
@oshai
Copy link
Author

oshai commented Feb 5, 2019

well, that is not accurate. docs are not in place yet but the artifact was created for 3.6.3: https://mvnrepository.com/artifact/io.vertx/vertx-mysql-postgresql-client-jasync

@jklingsporn
Copy link
Owner

jklingsporn commented Feb 5, 2019 via email

@oshai
Copy link
Author

oshai commented Feb 5, 2019

No, they decided to have 2 flavours for backward compatibility (from their readme):

There are two types of MySQL/PostgreSQL-clients:

(Soon to be legacy) Scala based version

(Soon to be may mainline) Kotlin based version

jklingsporn pushed a commit that referenced this issue Feb 5, 2019
@jklingsporn jklingsporn added this to the 4.1.0 milestone Feb 5, 2019
@jklingsporn
Copy link
Owner

@oshai
Copy link
Author

oshai commented Feb 5, 2019

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants