Add OffsetDateTime and Instant converters

[gurpreet-]

I wanted all my TIMESTAMP_WITH_TIMEZONE columns to be Instants rather than OffsetDateTimes (I presume OffsetDateTime is default for the type TIMESTAMP_WITH_TIMEZONE in postgres). So I created a converter of the type Converter<OffsetDateTime, Instant> that converted TIMESTAMP_WITH_TIMEZONE types to Instants. I.e. OffsetDateTimes to Instants.

However, this resulted in a ClassCastException: String cannot be converted to OffsetDateTime stemming from the converter.from(OffsetDateTime) method in AbstractAsyncQueryExecutor.

It was trying to force a string type into the from method of my converter, where it should have been an OffsetDateTime.

This PR fixes that problem by introducing bindings to the OffsetDateTime and Instant types and so therefore allows OffsetDateTime and Instant types to be retrieved from databases.

Thanks 👍

[jklingsporn]

Thank you very much for your PR. I will look into it when I come back from vacation in one week. Am 04.03.2018 12:20 vorm. schrieb "Gurpreet Paul" <notifications@github.com

…

: I wanted all my TIMESTAMP_WITH_TIMEZONE columns to be Instants rather than OffsetDateTimes (I presume OffsetDateTime is default for the type TIMESTAMP_WITH_TIMEZONE in postgres). So I created a converter of the type Converter<OffsetDateTime, Instant> that converted TIMESTAMP_WITH_TIMEZONE types to Instants. I.e. OffsetDateTimes to Instants. However, this resulted in a ClassCastException: String cannot be converted to OffsetDateTime stemming from the converter.from(OffsetDateTime) method in AbstractAsyncQueryExecutor <https://github.com/jklingsporn/vertx-jooq/blob/bb6b5fccbadf52fdb168e2d4d719b0fd742b14c3/vertx-jooq-shared-async/src/main/java/io/github/jklingsporn/vertx/jooq/shared/async/AbstractAsyncQueryExecutor.java#L47> . It was trying to force a string type into the from method of my converter, where it should have been an OffsetDateTime. This PR fixes that problem by introducing bindings to the OffsetDateTime and Instant types and so therefore allows OffsetDateTime and Instant types to be retrieved from databases. Thanks 👍 ------------------------------ You can view, comment on, or merge this pull request online at: #38 Commit Summary - Add OffsetDateTime and Instant converters File Changes - *M* vertx-jooq-shared-async/src/main/java/io/github/ jklingsporn/vertx/jooq/shared/async/AbstractAsyncQueryExecutor.java <https://github.com/jklingsporn/vertx-jooq/pull/38/files#diff-0> (18) Patch Links: - https://github.com/jklingsporn/vertx-jooq/pull/38.patch - https://github.com/jklingsporn/vertx-jooq/pull/38.diff — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#38>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AGC83mnjDgtSaHAXZrbWJ0bxPTrzbI67ks5tayVSgaJpZM4SbH7U> .