-
-
Notifications
You must be signed in to change notification settings - Fork 382
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unwrap Jackson2 Array and Object Nodes in JsonNodeValueResolver (#964, #969) #965
base: master
Are you sure you want to change the base?
Conversation
@jknack: What do you think of this update to the |
Added a fix for #969 as well since it's basically the same problem but on JSON objects instead of JSON arrays. After a JSON object is converted to a I fixed it in a distinct commit following the same "lazy" pattern of resolution and added a test. |
( •_•)σ @jknack Any objections? If not, is there a release guide? I don't mind going through the machinations. |
@jknack would we be able to get an update on this pull request or is there someone else who would be able to review these changes before they can be merged in? |
Hi, any updates as to when this PR could be merged? I have somewhat similar problem that Thank you |
Background
This is a fix for self-reported issue #964. Now the
JsonNodeValueResolver
resolves a Jackson2ArrayNode
as aList<Object>
with its items being recursively resolved.I wrote it in the same style as the
JsonNodeValueResolver.toMap()
method, meaning:JsonNode
.Testing
I wrote a few unit tests to verify the behavior works as expected. All of the existing unit tests pass without issue.