add 30 seconds to end_time of CameraEvent. Fixes #92 and #154 ... sorta #166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Per some of the feedback in #92, the only way I can think to improve this is to only add the 30 seconds to the end date based on the camera model (Nest Hello, Outdoor IQ) but I only have the Hello so I can't nail down the This will need to be added to a version posted to PyPi in order to get pulled into HomeAssistant to fix issues similar to |
|
\o/ I'll upload a release here shortly, I'm going to send you a request to be a collaborator on the repo as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.