Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrations for ArgoCD multi source application limitations #340

Merged
merged 7 commits into from
Feb 20, 2023

Conversation

jkroepke
Copy link
Owner

@jkroepke jkroepke commented Feb 18, 2023

What this PR does / why we need it:

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #337

Special notes for your reviewer:

PR Readiness Checklist:

Complete these before marking the PR as ready to review:

  • the CHANGELOG.md release notes have been updated to reflect any significant (and particularly user-facing) changes introduced by this PR

@codecov
Copy link

codecov bot commented Feb 18, 2023

Codecov Report

Base: 86.08% // Head: 85.71% // Decreases project coverage by -0.37% ⚠️

Coverage data is based on head (02e0a89) compared to base (4973088).
Patch coverage: 64.28% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #340      +/-   ##
==========================================
- Coverage   86.08%   85.71%   -0.37%     
==========================================
  Files          22       23       +1     
  Lines         812      826      +14     
==========================================
+ Hits          699      708       +9     
- Misses        113      118       +5     
Impacted Files Coverage Δ
scripts/wrapper/helm.sh 0.00% <0.00%> (ø)
scripts/lib/common.sh 70.83% <75.00%> (+0.83%) ⬆️
scripts/run.sh 90.67% <100.00%> (+0.24%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Repository owner deleted a comment from github-actions bot Feb 18, 2023
@jkroepke jkroepke changed the title Update ArgoCD docs Migrations for ArgoCD multi source application limitations Feb 18, 2023
@jkroepke jkroepke merged commit 34a9f3a into main Feb 20, 2023
@jkroepke jkroepke deleted the argocd-docs branch February 20, 2023 23:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ArgoCD: using "secrets://" does not work with values files from external Git repository
1 participant