Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow for use in other Packages #1

Merged
merged 3 commits into from
Aug 19, 2024
Merged

Allow for use in other Packages #1

merged 3 commits into from
Aug 19, 2024

Conversation

spprichard
Copy link
Contributor

@spprichard spprichard commented Aug 17, 2024 •
edited
Loading

  • Added library product to allow other packages to use this code

jkrukowski
jkrukowski reviewed Aug 18, 2024
View reviewed changes
Copy link
Owner

@jkrukowski jkrukowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution! Left some comments, lmk what you think

Package.swift Show resolved Hide resolved
Package.swift Outdated Show resolved Hide resolved
@spprichard
PR Comment Response
3bd4ca9 
- Min iOS version doens't need to be explicitly set
- Add CSQLiteVec as an importable product
@jkrukowski jkrukowski merged commit 138e790 into jkrukowski:main Aug 19, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkrukowski jkrukowski jkrukowski left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@spprichard @jkrukowski