Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

offsets #29

Merged
merged 6 commits into from
Jan 16, 2022
Merged

offsets #29

merged 6 commits into from
Jan 16, 2022

Conversation

jkrumbiegel
Copy link
Owner

  • add offset field, size field, change nrow/ncol
  • fix offset bugs

@codecov-commenter
Copy link

codecov-commenter commented Jan 12, 2022

Codecov Report

Merging #29 (28b68a6) into master (d19bdf5) will decrease coverage by 0.27%.
The diff coverage is 90.22%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #29      +/-   ##
==========================================
- Coverage   87.17%   86.89%   -0.28%     
==========================================
  Files           7        7              
  Lines        1318     1351      +33     
==========================================
+ Hits         1149     1174      +25     
- Misses        169      177       +8     
Impacted Files Coverage Δ
src/GridLayoutBase.jl 100.00% <ø> (ø)
src/precompile.jl 0.00% <ø> (ø)
src/helpers.jl 75.60% <71.42%> (-0.87%) ⬇️
src/gridlayout.jl 91.73% <92.37%> (-0.46%) ⬇️
src/types.jl 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d19bdf5...28b68a6. Read the comment docs.

@jkrumbiegel jkrumbiegel merged commit d3700e2 into master Jan 16, 2022
@jkrumbiegel jkrumbiegel deleted the offsets branch February 26, 2022 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants