Add option for opening keyboard after app drawer transition #107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- adds preferences in Customize App Drawer -> Open Keyboard
|
@hayribakici Thanks for the contribution! Sorry for the delayed response here. Life has been busy. I just wanted to let you know that I am going to have a look at these as soon as I get a chance, but it may be a little bit. |
jkuester
approved these changes
May 30, 2022
There was a problem hiding this comment.
@hayribakici I pushed a couple of changes here:
- In the drawer options, I dropped the "Visible Apps" list down into its own Fragment that is accessed via a button in the drawer options (instead of keeping it on the same screen as the other drawer options. This seems a bit more clean then trying to cram it all into the same fragment.
- I also moved the actual location the preference is stored from SharedPreferences into the Proto data store. I have been trying to put all new Unlauncher data/preferences into Proto since I like the idea of a single source of structured data as opposed to SharedPrefs + sqlite. (Of course, currently in the code base we have the worst situation where all the old Slim Launcher data is still in SharedPrefs/sqlite while the new Unlauncher settings/data are all in Proto, which I am sure is confusing to anyone trying to read this code. So, I apologize for that...)
Anyway, this is a great feature to have. Thanks again for contributing it! Let me know if you have any concerns or suggestions with my changes here. If it all looks good, I will get this merged!
|
@jkuester It's definitely good to have a single source of data as for future PR's. I also like the additional fragment for the visible apps. |
jkuester
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #47
it also adds the possibity to change that in the preferences in Customize App Drawer -> Open Keyboard. I wasn't 100% sure where else to put this preference (see screenshot). We can change it, if you think it belongs elsewhere.
The preference to open the keyboard is per default set to
truebecause, I also agree making the handling easier (see #47).