Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add popup menu for apps in the drawer #134

Merged
merged 6 commits into from
Oct 10, 2023
Merged

Add popup menu for apps in the drawer #134

merged 6 commits into from
Oct 10, 2023

Conversation

ru2saig
Copy link

@ru2saig ru2saig commented Dec 11, 2022

Addresses #69.

signal-2022-12-11-132646_002

@Nikl174
Copy link

Nikl174 commented Apr 13, 2023 •
edited
Loading

If it works correctly, i would appreciate to see this feature on the main release, maybe i will test it on the weekend on my phone. Thanks in advance @ru2saig for taking the time implementing it <3

@Nikl174
Copy link

Nikl174 commented May 30, 2023 •
edited
Loading

Finally found some time building it and it works, very nice :D, finally easy uninstall, rename etc. <3
Everything seams to work fine, going to test it further in the next weeks.

One thing i notice, i couldn't install the release build, only the debug one, not sure y though... Could you install the release build?

(And the keyboard bug #127 is also present, but this is another workspace.)
Again thx @ru2saig I hope this PR is merged soon

@ru2saig
Copy link
Author

ru2saig commented May 31, 2023 •
edited
Loading

Do you have more details? Did you build from this specific branch? I'm personally using v3.1.1-ruusaig from the releases page under my fork.

And for some reason the keyboard bug isn't occurring for me. I did set open keyboard option under Options > Customize Drawer > Open Keyboard, and I'm using one of the wallpaper themes.

jkuester
jkuester approved these changes Oct 10, 2023
View reviewed changes
Copy link
Owner

@jkuester jkuester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am sorry for the absurd delay in reviewing this! Thank you for this excellent contribution! 🎉

@jkuester jkuester changed the title A popup menu that displays options for apps in the drawer Add popup menu for apps in the drawer Oct 10, 2023
@jkuester jkuester merged commit b9a5a15 into jkuester:master Oct 10, 2023
This was referenced Oct 10, 2023
Closed
Closed
khwolf added a commit to khwolf/unlauncher that referenced this pull request Oct 30, 2023
@khwolf
Add icons to popup menu for the main apps
72a6179 
like jkuester#134 for popup menu in the drawer
@khwolf khwolf mentioned this pull request Oct 30, 2023
Merged
@khwolf khwolf mentioned this pull request Nov 9, 2023
Closed
@fusaty
Copy link

fusaty commented Dec 3, 2023 •
edited
Loading

Hi, is this feature part of the F-droid release? I would like to use it but it isn't working for me.

khwolf pushed a commit to khwolf/unlauncher that referenced this pull request Dec 22, 2023
@ru2saig @khwolf
Add popup menu for apps in the drawer (jkuester#134)
a69bafe
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkuester jkuester jkuester approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ru2saig @Nikl174 @fusaty @jkuester