fix(#163): remove uninstalled apps from home screen #164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hayribakici
changed the title
# Conflicts: # app/src/main/java/com/sduduzog/slimlauncher/ui/main/HomeFragment.kt
jkuester
approved these changes
Dec 28, 2023
There was a problem hiding this comment.
👍 Thank you!
For what its worth, I could never get _baseRepository.update to actually remove the apps that were not present in the list. I am not sure if I was just missing something there (like a race condition). But I ended up switching to just calling remove and placing all the filtering logic in the MainViewModel. Eventually, I plan to just replace the old SlimLanucher data structures with the new Unlauncher proto data structures. And at that point, the filtering logic can go away....
jkuester
changed the title
|
@jkuester Thank you for finishing this PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a draft PR that fixes #163