Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(#191): use alignment option in app drawer #200

Merged
merged 4 commits into from
Jan 2, 2024

Conversation

TobiTenno
Copy link
Collaborator

@TobiTenno TobiTenno commented Dec 30, 2023

Screenshot_20231230-141832.png

With most options available

@TobiTenno TobiTenno self-assigned this Dec 30, 2023
@jkuester
Copy link
Owner

@TobiTenno I would very much like your thoughts on the convo in #191! Should we just keep the functionality as it is now (maybe update the label for that option to be clear it is for the Home screen) and/or could we possibly repurpose this PR to be able to address #49?

Copy link
Owner

@jkuester jkuester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just updated the preference to be stored in the proto data store instead of adding a new SharedPreference value...

@jkuester jkuester merged commit 1dae8cd into master Jan 2, 2024
2 checks passed
@jkuester jkuester deleted the feat-drawer-alignment branch January 2, 2024 22:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants