chore: use dimension for most layout distances #201
Conversation
Define some dimensions in dimes.xml and reuse them as often as possible to unify the layout and make changing dimensions easier. (Might be a future feature to use more or less spacing)
| android:textSize="@dimen/font_size_home_date" | ||
| android:layout_marginTop="@dimen/_94sdp" | ||
| android:layout_marginTop="@dimen/_88sdp" |
There was a problem hiding this comment.
should this be like margin_top_huge?
There was a problem hiding this comment.
This one is special, as the top date is measured from the top of the parent, although the clock is in between. So maybe margin_top_home_date would be better?
There was a problem hiding this comment.
agreed, that would be better. I wasn't entirely sure of the rationale for the change regardless, so this is helpful context
There was a problem hiding this comment.
uh, @jkuester this was awaiting changes
There was a problem hiding this comment.
Whoops! 🤦 I misinterpreted your last comment without realizing @khwolf had offered an alternative in the previous comment....
I also just cut the beta release 😅, but if this is a necessary change we can get another PR up and merged before dropping 2.1.0...
There was a problem hiding this comment.
not necessary, it was just to round out the change. doesn't need to hold up the release
jkuester
changed the title
Define some dimensions in dimes.xml and reuse them as often as possible to unify the layout and make changing dimensions easier. (Might be a future feature to use more or less spacing)