Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix zlib library name #38

Merged
merged 1 commit into from
Jan 24, 2024
Merged

Fix zlib library name #38

merged 1 commit into from
Jan 24, 2024

Conversation

pema99
Copy link
Contributor

@pema99 pema99 commented Jan 24, 2024

The name of the zlib library in the zip files you are hosting (when using feature prebuilt) is "zlibstatic", not just "z". Without this fix, the following causes linker errors:

  • Clone repo
  • cargo build -F prebuilt

@pema99
Copy link
Contributor Author

pema99 commented Jan 24, 2024

image

@jkvargas jkvargas merged commit 0bbfb92 into jkvargas:main Jan 24, 2024
@jkvargas
Copy link
Owner

hey man, I had to revert your change since made the linux build fail.
But that was my fault since the runner was not working properly.
It should be fixed now.
Would you mind to send yet another PR? maybe a only on windows statement will be needed...
not sure =)

@pema99
Copy link
Contributor Author

pema99 commented Jan 24, 2024

@jkvargas I checked all 3 platform's zip files. Seems it's needed on all 3 - it's call zlibstatic on all
image
image
image
(these are all the dylib distributions)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants