Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Animation hook names as props to avoid global css #10

Open
ankitduseja opened this issue Jul 2, 2016 · 3 comments
Open

Animation hook names as props to avoid global css #10

ankitduseja opened this issue Jul 2, 2016 · 3 comments

Comments

@ankitduseja
Copy link

ankitduseja commented Jul 2, 2016

I am using CSS Modules and the animation hooks are currently static global classes. I think it will be good to have hook names be customised by passing them as props to the <Deck> and would help in avoiding global css completely.

@jl-
Copy link
Owner

jl- commented Jul 3, 2016

Hi @ankitduseja , thanks for bringing it up, and that's what should've been done at the beginning. I just made a new push to the demo, take a look at it, and readme here

@ankitduseja
Copy link
Author

ankitduseja commented Jul 3, 2016

Passing them individually to all children <Slide> makes it cumbersome, can we probably pass it once to the <Deck> to avoid repetition. Also just to avoid possible typos/confusion between className and classNames, a better prop name would like deckClasses/deckProps or slideClasses/slideProps.

jl- added a commit that referenced this issue Jul 3, 2016
jl- added a commit that referenced this issue Jul 3, 2016
jl- added a commit that referenced this issue Jul 3, 2016
@jl-
Copy link
Owner

jl- commented Jul 3, 2016

Right, classNames is really bad and confused. And on where to put this prop, I just imprudently go by the quick demo, should've been more careful.
I prefer <Deck slideClasses>,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants