GTC orders don't match properly #954
Comments
|
For what it's worth, I've tested this on both ERC20 and asset chains. The issue seems much worse on ERC20 (MYTH token in above logs) but it does also occur on asset chains. In the SUPERNET/KMD trade in these logs, Bob sees a |
|
Just to let you know I tried again with ERC20 and managed to get matches quicker when I set a higher price. Not sure if that's related (would explain why the issue is worse on ERC20 due to high TX fees making the price harder to predict) but no price mismatch errors are shown in the logs. It looks like it starts to match and the just stops. So this seems like an intermittent and hard to track down bug but definitely reproducible. |
|
what if you set a 10% higher price, with a small trade the txfees can dominate. if this is a pricing issue, the it is a pricing issue and nothing else to fix |
|
It's hard to choose what price I set because mm doesn't actually broadcast what I set. What I've been doing is setting a price. Viewing the broadcast price, then setting the Bob order after a little lower so I know it can match. Also, it would make sense that tx fees could affect things on ERC20 due to gas price fluctuations but aren't SUPERNET tx fees fixed? So the exact same Alice order shouldn't not match with Bob and then match 10 minutes later. |
|
You can view in my SUPERNET trade logs above, search for the value The behaviour isn't consistent with the same pricing so I don't think it's strictly a pricing issue. |
|
SUPERNET / KMD price is changing all the time if you are using autoprice |
|
testing close to the edge doesnt tell us if this is a pricing issue or something else |
I'm not, I'm using a fixed price on my Bob of 40 as you can see in the logs. |
DeckerSU
pushed a commit
to DeckerSU/SuperNET
that referenced
this issue
Nov 5, 2022
* ARRR wip. Add dex_fee script with tests. * WIP. * Fix clippy. * WIP. Demo of adding redeem script to the OP_RETURN. * Add full redeem script to OP_RETURN of ARRR swap_payment_outputs. * Fix tests compilation. * WIP SLP OP_RETURN parsing. * WIP adding ZAddrCoin. * WIP implementing ZCoin. HTLC tx fails. * Fix op_return for z_sendmany. HTLC broadcast worked. * WIP zombie_coin_send_htlc_maker_payment success. * WIP implementing HTLC refund. * WIP trying to build transaction using pure Rust with librustzcash. * WIP built and signed z output tx using pure rust, refactor. * Fix WASM and clippy. * WIP refactoring. * WIP refactoring. * WIP z_send_dex_fee * WIP. * WIP. * WIP. Made the first RICK/ZOMBIE swap. * Put ZCoin under zhtlc feature to avoid bundling Sapling params. * Fix after merge. * Fix WASM tests compilation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
If Alice places a GTC order that can be instantly matched with Bob it works fine. However, if Alice places a GTC order that can't instantly be matched, once there is an inverse Bob order available it has a lot of issues been matched.
Bob can see the Alice
requestmessages and will respond with areservedmessage but the trade doesn't seem to progress past that.This happens repeatedly every time Alice re-issues the order.
Tracking this here following on from our conversations in #tradebots Discord:
Logs from my Bob (MYTH/KMD swap):
The text was updated successfully, but these errors were encountered: