Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow direct download as an attachment #62

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

crsct
Copy link

@crsct crsct commented May 16, 2024

No description provided.

@sjanssen2
Copy link
Member

I've experienced that people struggled to find the right editor to "open" / view the downloaded *.gap files. Therefore, I prefer the browser directly to show the raw file content.
@crsct you said that there was some issue with the encoding when saving the file to disk. Is this due to the wrong mime type?

@crsct
Copy link
Author

crsct commented May 20, 2024

I checked the mime type, it is set to text/plain, if clicked as is, it opens the raw content in a new tab, which cant be downloaded by "ctrl+s" or "save as" in the context menu, this will only result in a downloaded html file and a folder with files in it (arbritary name, but content of alignments.gap).

If the point is to show them the raw file content, would it be better to have a dedicated download page that has buttons to download the file as an attachment (as it is in this PR) and a text preview akin to github?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants