Use Webview to manage cluster settings

[angelozerr]

Use Webview to manage cluster settings

Fixes #88

Signed-off-by: azerr azerr@redhat.com

[fbricon]

• Page title should be "Edit Kafka cluster" or (New Kafka cluster)
• Header on top should be removed
• Cluster block should move up
• labels and text fields should be aligned and having the same width
• Authentication "None" should have a label
• Hide Back/Next, Finish -> Save

[angelozerr]

Please note now I'm consuming 0.2.5 vscode-wizard which has been published (which fixes some bugs that you mentionned)

Page title should be "Edit Kafka cluster" or (New Kafka cluster)

Fixed (for the moment I manage only Edit)

Header on top should be removed

Fixed by 0.2.5

Cluster block should move up

Sorry I don't understand what you mean?

labels and text fields should be aligned and having the same width

Fixed, but there is a problem with select that I have reported in redhat-developer/vscode-wizard#33

Authentication "None" should have a label

Fixed

Hide Back/Next, Finish -> Save

TODO

[angelozerr]

Here the current result:

[angelozerr]

I pushed a new commit, I have started to declare the UI for SSL:

Please note:

• we should add a browse button to select the proper file for each ca,cert,key files. See Provide UI file type redhat-developer/vscode-wizard#34
• for the moment it's the UI, I need to write code to use value of those fields.

[rgrunber]

I'd probably use the full name of the term.
Ca -> Certificate Authority (CA)
Cert -> Certificate

I don't think the SSL checkbox should exist. The underlying field, cluster.ssl should simply be set to true when the other 3 fields are valid/non-empty.

[fbricon]

@rgrunber no you can set SSL=true without specifying certs

[angelozerr]

I'd probably use the full name of the term.
Ca -> Certificate Authority (CA)
Cert -> Certificate

Fixed

I don't think the SSL checkbox should exist. The underlying field, cluster.ssl should simply be set to true when the other 3 fields are valid/non-empty.

As @fbricon said we can enable SSL without certificates

[angelozerr]

Just for your information I created a PR redhat-developer/vscode-wizard#37 to improve UI, here the result with light:

and with dark

[fbricon]

certificate/key files should allow ".pem" and other file extensions (see https://kafka.js.org/docs/configuration#ssl and https://www.ssl.com/guide/pem-der-crt-and-cer-x-509-encodings-and-conversions/)

[angelozerr]

New Cluster(s) title should be "Add New Cluster(s)"

fixed

cluster provider: remove the "none" option, have "configure manually" preselected

fixed

cluster provider combo should not crop selected provider

it's an issue for vscode-wizard, see redhat-developer/vscode-wizard#58

If vscode-rhoas is installed, you select the Red Hat provider, click finish, the wizard stays opened. It should close. If you click finish a 2nd time, it closes.

That's strange, I cannot reproduce on Windows OS?

[fbricon]

When renaming a cluster, the selected cluster in the status bar is not renamed

[angelozerr]

When selecting SASL/*, the SSL box is not automatically checked, rendering the cluster unable to connect.

I cannot do that with vscode-wizard, but I validate that:

When creating a new cluster, the wizard is stil opened after saving

I cannot reproduce it -(

If you click save again, after checking the ssl box, a "Cluster name 'foo' already exists." error is shown. The wizard should be closed, or at the very least should enter edit mode.

fixed

When editing an existing cluster:

change name
save
check SSL => cluster name already exists

Same error than below, fixed

certificate/key files should allow ".pem" and other file extensions (see https://kafka.js.org/docs/configuration#ssl and https://www.ssl.com/guide/pem-der-crt-and-cer-x-509-encodings-and-conversions/)

I add other extensions according to https://www.tutorialsteacher.com/https/ssl-certificate-format

Here the filters now:

I allow . because I fear to forget some file extensions.

[angelozerr]

When renaming a cluster, the selected cluster in the status bar is not renamed

fixed

[angelozerr]

@fbricon everything should be fixed exept:

• UI problem, I have created an issue in vscode-wizard Size problem of UI redhat-developer/vscode-wizard#58
• disabled of fileds according to combo mechanism, select SSL checkbox when mechanims != none, I have created an issue in vscode-wizard How to manage property fields (disabled,checked, etc) according value of another field? redhat-developer/vscode-wizard#59

[fbricon]

Nice work @angelozerr! Thanks!