Ability to group several build definitions #12
Conversation
|
Hey, thanks for the PR! Will be happy to bring this feature into this extension. I will take a look at it asap. |
|
@jlandersen when do you plan to look into it? Just to let you know - another thing on my to-do list is to move authentication password out from settings (e.g. to OS native password storage). Not sure yet by which means to do it yet (proposing credentials API for VS Code or leveraging existing solutions as |
|
Apologies, I have been away for a few days - my plan was to look at it and hopefully get it merged + pushed on Wednesday (so just a couple of more days :-) ). Re moving auth passwords out. It definitely makes sense. I was thinking of environment variables at one point, but if you have better suggestions I am open for merging it in as well! |
|
@jlandersen Thanks, I will check back on Wednesday then. Environment variables are not also very safe, but considered it also at one point. Thus, I've made a proposal for credentials API in VS Code with a potential to leverage it - microsoft/vscode#15414 (comment). |
src/vstsbuildstatus.ts
Outdated
| if (!this.activeDefinition) { | ||
| this.statusBar.displayInformation("Select build definition", ""); | ||
|
|
||
| if (!this.activeDefinitions) { |
There was a problem hiding this comment.
You need to extend this condition to handle the initial case where activeDefinitions is an empty array. It is no longer null initially. As a result line 72 fails because it expects an item at position 0.
There was a problem hiding this comment.
Good catch! Sorted.
|
Great, thanks a lot! |
|
0.7.0 is live on the marketplace |
|
Perfect, thank you @jlandersen ! |
As part of work on automating smoke tests for VS Code and creating build definitions to run them scheduled (see microsoft/vscode#28586 and microsoft/vscode#27845) I found your extension that provides capabilities we want to use in our dev work - such as seeing status of the builds in the status bar. I'd like to thank you for building it!
One missing piece was that you cannot group build definitions in a single status indicator. We have the following scenario which made me to do this PR:
Hence, I forked your extension and worked on some amends that required to enable grouped build. I also did little cosmetic changes in
vstsbuildstatusbar.ts.It would be great if you can merge those in, however if you feel that this functionality is out of scope for your extension, then I will publish a separate extension, mentioning that it is a fork of yours. Let me know what is more acceptable for you 🙂
Thank you.