Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recreate the notification icon on failure to add it. #6

Merged
merged 1 commit into from
Jul 8, 2024

Conversation

Eiyeron
Copy link
Contributor

@Eiyeron Eiyeron commented Jul 6, 2024

Hello.

This is one solution to close #5, if we assume that the GUID will be effecitvely unique, we're able to delete and recreate the notification icon and continue as usual.

Until we get a "cleaner" solution or want to switch to using different GUIDs until one works, I believe this method would be satisfactory enough.

SIdenote : I saw some software already using multiple GUIDs, like Live++ in some situations.

@Eiyeron Eiyeron marked this pull request as ready for review July 6, 2024 19:39
@jlaumon
Copy link
Owner

jlaumon commented Jul 8, 2024

I remember this being a very clear issue in the past, and I see the issue with Live++ on my work PC (where the icon stays after Live++ has been killed, and it goes away if I hover it with the mouse). But I can't repro the issue on my home PC (maybe Windows 11 is handling that better now? No idea).

Anyway, if that works, that's the best solution I think. Thank you!

@jlaumon jlaumon merged commit 42599c9 into jlaumon:main Jul 8, 2024
1 check passed
@Eiyeron
Copy link
Contributor Author

Eiyeron commented Jul 8, 2024

Maybe Windows 11 is handling that better now? No idea.

This is maybe a good reason why it'd not reproduce on your computer: it doesn't on my PC running Windows 11 and only noticed it to happen on my older PC running on Windows 10. I hadn't connected the dots until you pointed that fact out, nice catch!

@jlaumon
Copy link
Owner

jlaumon commented Jul 8, 2024

Incredible to think Microsoft is also sometimes fixing things in new versions of windows! 🤣

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Notification icon fails to create in some scenarios
2 participants