-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CodeBlocks nested in lists aren't turned into runnable blocks #114
Comments
RunMe has already solved this problem. They have a [Deserialize method] (https://github.com/stateful/runme/blob/61fc8785ab8adb4cec5f1135d278a9e8895f327c/internal/document/editor/editor.go#L20) That takes as input
In principle we could reuse that method. Unfortunately; we can't just import it because its in the internal package. |
I think we should consider refactoring so we can just reuse it. |
The purpose of this PR is to make it possible to reuse runme's Markdown -> Notebook code. In particular I'd like to use it to parse ChatGPT output into a notebook so that code blocks can be rendered in RunMe notebooks. In Foyle, there is currently a bug with parsing out code blocks nested inside lists jlewi/foyle#114. Runme's code properly handles this use case. This will allow us to reuse RunMe's code to fix this problem.
Duplicate of #55 |
Reported in discord thread
This looks like code blocks nested inside a list. I suspect the text language id is coming from OpenAI. I think the issue is MarkdownToBlocks won't parse out code blocks nested in a list.
Our unittest doesn't cover nested blocks so we should try to reproduce that error in the unittests
foyle/app/pkg/docs/converters.go
Line 60 in fe1bf81
The text was updated successfully, but these errors were encountered: