Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CORS support so server can work the vscode test web server. #18

Merged
merged 2 commits into from
Apr 5, 2024

Conversation

jlewi
Copy link
Owner

@jlewi jlewi commented Apr 5, 2024

  • When vscode test server runs the frontend will be using a different host and port then the backend so we have CORS issues

  • Add CORS support to the server so we can use it when developing the frontend

  • It looks like the test server or chromium generates a random hostname so we need to add special support to CORS to be able to deal with this

jlewi added 2 commits April 5, 2024 07:31
* When vscode test server runs the frontend will be using a different
  host and port then the backend so we have CORS issues

* Add CORS support to the server so we can use it when developing the frontend

* It looks like the test server or chromium generates a random hostname
  so we need to add special support to CORS to be able to deal with this
@jlewi jlewi merged commit 3620389 into main Apr 5, 2024
1 check passed
@jlewi jlewi deleted the jeremy/cors branch April 5, 2024 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant