Flush out calling execute and serialization in the vscode extension #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Update buf to generate typescript protos that we can use the vscode extension * Create a client class in typescript to send execute requests to the backend * Create a minimal implementation of the notebook controller that is capable of executing cells by sending the requests to the backend. * Implement serialization of the notebooks * We needed to add more CORS support to handle the fact that certain assets are served from vscode-cdn.net * Otherwise the webviews don't render
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update buf to generate typescript protos that we can use the vscode extension
Create a client class in typescript to send execute requests to the backend
Create a minimal implementation of the notebook controller that is capable of executing cells by sending the requests to the backend.
Implement serialization of the notebooks
We needed to add more CORS support to handle the fact that certain assets are served from vscode-cdn.net