Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LogAnalysis should not rely on cell execution being recorded by LogEvents #222

Merged
merged 10 commits into from
Sep 7, 2024
Merged

LogAnalysis should not rely on cell execution being recorded by LogEvents #222

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
c36dea9
Now that we no longer need to process RunMe logs we can simplify log …
jlewi Aug 29, 2024
5cbdc96
Cleanup some deadcode.
jlewi Aug 29, 2024
059ed92
Update the code to process the logevents.
jlewi Aug 30, 2024
1417588
I think we can remove ExecuteTrace.
jlewi Aug 30, 2024
387b514
Analyzer test is passing.
jlewi Aug 30, 2024
2aea34f
Tidy.
jlewi Aug 30, 2024
56f8bac
Fix locking test.
jlewi Aug 30, 2024
d43b3e4
Fix imports.
jlewi Aug 30, 2024
a00ac9b
Merge remote-tracking branch 'origin/main' into jlewi/main
jlewi Aug 30, 2024
b47f046
Merge remote-tracking branch 'origin/main' into jlewi/main
jlewi Sep 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion app/pkg/agent/agent.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -529,7 +529,8 @@ func (a *Agent) LogEvents(ctx context.Context, req *connect.Request[v1alpha1.Log
func() {
_, span := tp.Start(ctx, "LogEvent", trace.WithAttributes(attribute.String("eventType", event.Type.String()), attribute.String("contextId", event.ContextId), attribute.String("selectedCellId", event.SelectedId)))
defer span.End()
log.Info("LogEvent", "eventType", event.Type, "contextId", event.ContextId, "selectedCellId", event.SelectedId, "event", zap.Object("event", event))
// N.B we can't use zap.Object to log the event because it contains runme protos which don't have the zap marshaler bindings.
log.Info("LogEvent", "eventId", event.GetEventId(), "eventType", event.Type, "contextId", event.ContextId, "selectedCellId", event.SelectedId, logs.ZapProto("event", event))
}()
}
return connect.NewResponse(&v1alpha1.LogEventsResponse{}), nil
Expand Down
Loading
Loading