Add logging to confirm that stdout isn't empty when triggering on cell execution #333
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…l execution. * The purpose of this PR is to add logging to confirm that #309 is fixed; i.e. that when triggering on cell execution for interactive (and non interactive cells) the output is included in the request * This PR adds logging that checks if the selected cell has non-empty stdout if its empty we log a message. The presence of these log messages thus indicates cell execution triggered completion that included no stdout. * This will include false positives because in certain cases the command may not produce any output. * With this logging I was unable to reproduce any instances where completion was triggered by cell execution but stdout wasn't included. * This PR fixes a bug in the mimetype for stdout; there was an extra space. I don't think that actually impacted processing because that constant was only used in unittests before this PR. * fix #309
![standard-input[bot]](https://avatars.githubusercontent.com/in/1011034?s=60&v=4){kind=small}
jlewi
changed the title
✅ Deploy Preview for foyle canceled.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The purpose of this PR is to add logging to confirm that Trigger Foyle Ghost Cell Updates When Cell Output Changes / Cell Is Executed #309 is fixed; i.e. that when triggering on cell execution for interactive (and non interactive cells) the output is included in the request
This PR adds logging that checks if the selected cell has non-empty stdout if its empty we log a message. The presence of these log messages thus indicates cell execution triggered completion that included no stdout.
This will include false positives because in certain cases the command may not produce any output.
With this logging I was unable to reproduce any instances where completion was triggered by cell execution but stdout wasn't included.
This PR fixes a bug in the mimetype for stdout; there was an extra space. I don't think that actually impacted processing because that constant was only used in unittests before this PR.
fix Trigger Foyle Ghost Cell Updates When Cell Output Changes / Cell Is Executed #309