Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve observability; add sqlite retries to deal with sqlite_busy errors #352

Merged
merged 7 commits into from
Dec 4, 2024

Conversation

jlewi
Copy link
Owner

@jlewi jlewi commented Dec 4, 2024

  • Use the pragma sqlite_busy to add automatic retries on sqlite busy error

    • I was seeing high rates of sqlitebusy errors when deployed on K8s on Azure and this was causing learning to happen much less frequently then it should
  • Clean up the prometheus metrics to support dashboards for monitoring impact. The key metrics we want are

    • Number of accepted suggestions
    • Number of executed cells
    • Number of learned examples
  • Cleanup up prometheus metrics so we can better monitor why learning isn't happening; this was used to track down sqlite busy errors

  • Support monitoring with Datadog

    • With Datadog structured logging we need to use the field "level" for severity or else it won't automatically parse that field
    • Udpate the configuration to allow the user to control what fields are used in the encoder

Copy link
Contributor

@standard-input standard-input bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues flagged.
Standard Input can make mistakes. Check important info.

Copy link

netlify bot commented Dec 4, 2024

Deploy Preview for foyle ready!

Name Link
🔨 Latest commit 2c346b6
🔍 Latest deploy log https://app.netlify.com/sites/foyle/deploys/674faf66842bb40008a05a86
😎 Deploy Preview https://deploy-preview-352--foyle.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@jlewi jlewi enabled auto-merge (squash) December 4, 2024 01:25
@jlewi jlewi merged commit a3a7611 into main Dec 4, 2024
5 checks passed
@jlewi jlewi deleted the jlewi/datadog branch December 4, 2024 01:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant