DirectoryHelper with Glob support; GCS NewWriter should truncate #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
jlewi
commented
Jun 21, 2024
jlewi
commented
- Create a new interface DirectoryHelper which includes support for matching globs
- Change the semantics of Gcs.NewWriter to not return an error if the object exists
- Instead just truncate the object
- This is consistent with the LocalFileHelper which uses os.Create
- If the caller doesn't want to overwrite existing objects they should call Exists to check if it already exists.
- Remove duplicate code
- For some reason the gcs package was defining the interface and LocalFileHelper.
- This was probably a result of not deleting code after refactoring into a separate package
- That probably happened when the code was in the hydros repository.
* Create a new interface DirectoryHelper which includes support for matching globs * Change the semantics of Gcs.NewWriter to not return an error if the object exists * Instead just truncate the object * This is consistent with the LocalFileHelper which uses os.Create * If the caller doesn't want to overwrite existing objects they should call Exists to check if it already exists. * Remove duplicate code * For some reason the gcs package was defining the interface and LocalFileHelper. * This was probably a result of not deleting code after refactoring into a separate package * That probably happened when the code was in the hydros repository.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.