#168 Fix browser not opening on Windows when using the CLI (#307)

jlfwong · Sep 14, 2020 · 069c019 · 069c019
1 parent 64fe369
commit 069c019
Show file tree

Hide file tree

Showing 3 changed files with 35 additions and 5 deletions.
diff --git a/bin/cli.js b/bin/cli.js
@@ -4,7 +4,7 @@ const fs = require('fs')
 const os = require('os')
 const stream = require('stream')
 
-const opn = require('opn')
+const open = require('open')
 
 const helpString = `Usage: speedscope [filepath]
 
@@ -89,7 +89,11 @@ async function main() {
 
   console.log('Opening', urlToOpen, 'in your default browser')
 
-  await opn(urlToOpen, {wait: false})
+  // We'd like to avoid blocking the terminal on the browsing closing,
+  // but for some reason this doesn't work at all on Windows if we
+  // don't use wait: true.
+  const wait = process.platform === "win32";
+  await open(urlToOpen, {wait})
 }
 
 main()

diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -79,7 +79,7 @@
     ]
   },
   "dependencies": {
-    "opn": "5.3.0",
+    "open": "7.2.0",
     "react": "^16.13.1"
   }
 }