Skip to content

Commit

Permalink
Fix schema generation in new TypeScript version (#274)
Browse files Browse the repository at this point in the history
Fixes #268 

I fixed it by dropping the dependency on quicktype entirely, and using its dependency directly. I still don't understand why the version of typescript used in this repository affects what quicktype is doing, but it seems like the issue is in quicktype, not its dependency.

I validated this change was correct by diffing the output of `node scripts/generate-file-format-schema-json.js` with what's currently on http://speedscope.app/file-format-schema.json. There's no difference.

This PR also includes changes to the CI script to ensure that we can catch this before hitting master next time.
  • Loading branch information
jlfwong authored May 23, 2020
1 parent dee9e5a commit ca1abfd
Show file tree
Hide file tree
Showing 4 changed files with 119 additions and 604 deletions.
Loading

0 comments on commit ca1abfd

Please sign in to comment.