Dev-only: hot reloading broken after preact changes #276
Comments
jlfwong
added a commit
that referenced
this issue
May 25, 2020
To test this, load a profile, then save a `.tsx` file locally. Before this change, it would bring you back to the welcome screen after hot reload. After this change, application state is still displayed. This is because before the change, the `setGLCanvas` action wasn't resulting in a re-render because it occurred between the initial render and the `useLayoutEffect` callback. Fixes #276
jackerghan
pushed a commit
to jackerghan/speedscope
that referenced
this issue
Jul 28, 2023
…wong#279) To test this, load a profile, then save a `.tsx` file locally. Before this change, it would bring you back to the welcome screen after hot reload. After this change, application state is still displayed. This is because before the change, the `setGLCanvas` action wasn't resulting in a re-render because it occurred between the initial render and the `useLayoutEffect` callback. Fixes jlfwong#276
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The changes I mean in #267 seem to have broken hot reloading. This isn't a show stopper, but it's pretty annoying.
I'm going to punt on this because I want to try switching to recoil anyway, which might change how some of this works).
The text was updated successfully, but these errors were encountered: