Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Navigating grouped candidates using arrow keys is broken #580

Closed
mattirn opened this issue Sep 25, 2020 · 1 comment
Closed

Navigating grouped candidates using arrow keys is broken #580

mattirn opened this issue Sep 25, 2020 · 1 comment
Labels
Milestone

Comments

@mattirn
Copy link
Collaborator

mattirn commented Sep 25, 2020

Navigating grouped command candidates is broken. There are also other problems if the grouped candidates do not fit to the terminal display.

Example: From the initial position BYTES pressing once the left arrow key selected candidate moves to toHexString

menu_1

menu-2-left-arrow

Solution: Grouping of the candidates is removed when starting to navigate candidates.

@bdw429s
Copy link
Contributor

bdw429s commented Dec 5, 2020

This was the wrong solution to just remove functionality instead of fixing it. Please restore the missing and useful functionality of candidate grouping.

See: #613

And if JLine follows semantic versioning, it was also incorrect to introduce a breaking change into a minor release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants