Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tab completion loses groups when tabbing (3.17 regression) #613

Closed
bdw429s opened this issue Dec 5, 2020 · 3 comments
Closed

Tab completion loses groups when tabbing (3.17 regression) #613

bdw429s opened this issue Dec 5, 2020 · 3 comments
Milestone

Comments

@bdw429s
Copy link
Contributor

bdw429s commented Dec 5, 2020

In JLine 3.16.0 I can keep pressing tab to iterate through my options as shown. Notice I'm grouping the completion candidates into groups.

image

However, in 3.17.1 the groups display initially like above when I press tab, but when I press tab subsequent times to begin toggling through the options, the screen redraws without any of the groups.

image

This regression remains in the 3.17.2-SNAPSHOT build.

@bdw429s
Copy link
Contributor Author

bdw429s commented Dec 5, 2020

cc/ @mattirn

@mattirn
Copy link
Collaborator

mattirn commented Dec 5, 2020

Navigating grouped candidates has been disabled in #580.
I can add JLine option to preserve the old behaviour.

@mattirn mattirn added this to the 3.17.2 milestone Dec 5, 2020
@bdw429s
Copy link
Contributor Author

bdw429s commented Dec 5, 2020

@mattirn Wait, what? Completion groups are awesome! Why would you disabled them? My console app regularly has 3 or 4 different groups for all the possible completion candidates and I'd hate to see that functionality go away as it really helps organize what's on the screen.

image

Without the nice, clear grouping in the UI, the same list is just a jumbled mess

image

I'm concerned about features like this being dropped in a minor version release without even having any conversation on the JLine mailing list about it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants