cmake simplifications, static offsets and lightweight update generator #49
Conversation
|
@FabienPean Do you have time to take a look at the cmake bits? I removed the auto-download code. I feel that it does not make sense anymore, now that we have serious package managers. |
| if(CMAKE_COMPILER_IS_GNUCXX OR COMPILER_IS_CLANG) | ||
| add_compile_definitions(_GLIBCXX_DEBUG) |
There was a problem hiding this comment.
This would add the definition on Windows if Clang is detected, not sure it matters though
| if (NOT (MSVC AND YOMM2_SHARED)) | ||
| # Running this example with a Windows DLL is too much of a hassle, because we | ||
| # would need to add the path to the directory containing yomm2.dll to PATH. | ||
| # Anyway, if it works with static linking, it is very unlikely that it fails | ||
| # with the runtime in a DLL. |
There was a problem hiding this comment.
In recent CMake versions there is this generator expression that can help with DLL in case the example on Windows is desirable for completeness https://cmake.org/cmake/help/latest/manual/cmake-generator-expressions.7.html#genex:TARGET_RUNTIME_DLLS
There was a problem hiding this comment.
Supporting DLLs on Windows has cost me a huge amount of time and effort. I started work on v2, which will break backward compatibility. As a consequence of one of the changes (a small one for that matter) I plan to drop the shared library build, and have header-only the only option. Also, I doubt few people will ever use the generator, and, those who do, will most likely use a trimmed down policy. What I pre-instantiate in the DLL contains everything, even if the consumer is built for release.
| "boost-mp11", | ||
| "boost-preprocessor", | ||
| "boost-test", | ||
| "vcpkg-tool-ninja" |
There was a problem hiding this comment.
I have never used vcpkg in manifest mode, so I am not sure, but is vcpkg-tool-ninja needed (or it might be a host only dependency? https://learn.microsoft.com/en-us/vcpkg/concepts/manifest-mode#package-manifest-example)
There was a problem hiding this comment.
My goal is to make it as easy as possible for a developer, or CI, to grab everything that is needed to build the library, including test, examples and benchmarks. Yeah I considered moving the Ninja requirement to CMakeUserPresets.json but CI did not have it on Windows IIRC. Just being practical, it is a dev time only dep.
Co-authored-by: Fabien Péan <fabien@pean.pro>
Co-authored-by: Fabien Péan <fabien@pean.pro>
|
Thanks for the review! |
No description provided.