Ignoring /out/ instead of out to ignore only out folder #122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ohhh thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Today @ogom alerted me at NodeSchool that the deployed version is missing Section 9 "9_pull_never_out_of_date.html". It does so because the scripts to package the application specifies
--ignore=outwhere "out" stands fornew RegExp("out")on the file path and effectively filters out also the...ver_out_of...part of this the sections file name! This PR replaces the section with a/out/that will include the section again.Note: I also opened node-fs-extra#239 in order to get a better API for the electron packager.