Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

typing updates #17

Merged
merged 5 commits into from
Dec 1, 2024
Merged

typing updates #17

merged 5 commits into from
Dec 1, 2024

Conversation

zzstoatzz
Copy link
Collaborator

@zzstoatzz zzstoatzz commented Nov 30, 2024

looks like main is hot so will rebase and update


this PR

  • fixes typing in server.py
  • adds precommits + CI job
  • updates publish CI to use uv

lemme know if you want to avoid any of this for now, just getting oriented and yak shaving

fix pyproject groups

fix lockfile

add pre-commit ci

actually run ruff and fix things
@zzstoatzz zzstoatzz requested a review from jlowin November 30, 2024 23:37
@zzstoatzz zzstoatzz marked this pull request as ready for review November 30, 2024 23:37
@@ -24,15 +24,18 @@ build-backend = "setuptools.build_meta"
[tool.setuptools_scm]
write_to = "src/fastmcp/_version.py"

[dependency-groups]
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dev was not being recognized as a valid group

@@ -176,7 +180,7 @@ async def list_resource_templates(self) -> list[MCPResourceTemplate]:
for template in templates
]

async def read_resource(self, uri: _BaseUrl) -> Union[str, bytes]:
async def read_resource(self, uri: AnyUrl | str) -> str | bytes:
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can have nice union syntax now 🙂

Copy link
Owner

@jlowin jlowin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@jlowin jlowin merged commit 6e71950 into main Dec 1, 2024
2 checks passed
@jlowin jlowin deleted the updates branch December 1, 2024 00:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants