Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Azure storage updates #47

Merged
merged 2 commits into from
Dec 13, 2023
Merged

Azure storage updates #47

merged 2 commits into from
Dec 13, 2023

Conversation

jluevan13
Copy link
Owner

No description provided.

Copy link

@prisma-cloud-devsecops prisma-cloud-devsecops bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Prisma Cloud has found errors in this PR ⬇️

@@ -82,6 +82,7 @@ resource "azurerm_storage_account" "example" {
}

resource "azurerm_storage_container" "example" {
# this blob container is public

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

HIGH  Azure storage account has a blob container that is publicly accessible
    Resource: azurerm_storage_container.example | Checkov ID: CKV_AZURE_34

How to Fix

resource "azurerm_storage_container" "example" {
    ...
+   container_access_type = "private"
}

Description

Anonymous, public read access to a container and its blobs can be enabled in Azure Blob storage.
It grants read-only access to these resources without sharing the account key or requiring a shared access signature.
We recommend you do not provide anonymous access to blob containers until, and unless, it is strongly desired.
A shared access signature token should be used for providing controlled and timed access to blob containers.

@@ -49,8 +50,12 @@ resource "aws_ebs_volume" "web_host_storage" {
git_repo = "terragoat"
yor_trace = "c5509daf-10f0-46af-9e03-41989212521d"
})

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

HIGH  AWS EBS volumes are not encrypted
    Resource: aws_ebs_volume.web_host_storage | Checkov ID: CKV_AWS_3

How to Fix

resource "aws_ebs_volume" "example" {
  ...
  availability_zone = "${var.availability_zone}"
+ encrypted         = true
  ...
}

Description

Encrypting EBS volumes ensures that replicated copies of your images are secure even if they are accidentally exposed.
AWS EBS encryption uses AWS KMS customer master keys (CMK) when creating encrypted volumes and snapshots.
Storing EBS volumes in their encrypted state reduces the risk of data exposure or data loss.
We recommend you encrypt all data stored in the EBS.

@jluevan13 jluevan13 merged commit 61ab9e3 into master Dec 13, 2023
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant