-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix for Xiaomi Aqara gateway #101
Conversation
Some devices send their services and characteristics in lowercase: Xiaomi aqara gateway (Homekit version)
Some devices send their services and characteristics in lowercase Xiaomi Aqara gateway (Homekit version)
Hi @quarcko thank you for your PR, but we have to fix the errors in the tests first. Can you give me an example what the Xiaomi Aqara exactly returns? I guess just making stuff upper case in the place you propse can't work all the way down, because the input may also be an integer. Regards |
Here is a diff between output with 'upper()' and without: I think i just overreacted with it. It is enough to make 'upper()' only in get_short() but:
|
good point, not sure, can you extend the pull request like this:
Perhaps we should check if anything being a UUID is ok upper and lower case |
Thank you! |
This gateway sends all his characteristics and services using lowercase letters.
Thus your library cannot identify some of information.
Quick fix to make uppercase-comparisons despite input being lowercase.