Basic threading functionality for 'get_events' #115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added an optional semaphore that tells get_events to stop. Also, added a stop_events to cleanly tell the accessory to stop sending events to us. Combined some of the functionality of get_events into put_characteristics, so put_characteristics is now more flexible (can be called with both the field that should be updated, as well as a default value to set multiple characteristics at once)
|
Looks cool! if acceptable, please contribute to the tests. Is it possible to integrate the new feature somehow into |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added an optional semaphore that tells get_events to stop. Also, added a stop_events to cleanly tell the accessory to stop sending events to us.
Combined some of the functionality of get_events into put_characteristics, so put_characteristics is now more flexible (can be called with both the field that should be updated, as well as a default value to set multiple characteristics at once)