Global initialization and resources proposal: demonstration #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 12, 2019
krnowak
reviewed
Aug 13, 2019
| func (k Key) Defined() bool { | ||
| return k.Variable.Defined() | ||
| } | ||
|
|
||
| // TODO make this a lazy one-time conversion. | ||
| func (v Value) Evaluate() Value { |
There was a problem hiding this comment.
The issue of making a copy of the Value object was brought up in the #59 too. So just to keep track of that I'll mention it here: the BYTES case should also be handled here by making a new slice and copying a contents of the original slice into the new slice.
bogdandrutu
reviewed
Aug 22, 2019
| @@ -26,8 +43,8 @@ type Value struct { | |||
| Float64 float64 | |||
| String string | |||
| Bytes []byte | |||
There was a problem hiding this comment.
This is not a type that we have in the OpenTelemetry specs.
bogdandrutu
reviewed
Aug 22, 2019
| @@ -164,8 +222,10 @@ func (v Value) Emit() string { | |||
| return fmt.Sprint(v.Float64) | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is not meant to merge as a single PR, as it contains too many separate parts (which should be tested). This is meant to show the final state referred to in several RFCs with respect to initializing globals and setting up resources.
I expect this does not go far enough, probably we'll want to introduce some sort of Tracer/Meter builder concept, as discussed here: open-telemetry/opentelemetry-specification#10 (comment)