Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: simplify string formatting for readability #298

Conversation

hamirmahal
Copy link
Contributor

No description provided.

Copy link
Contributor Author

@hamirmahal hamirmahal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This shouldn't cause any user-facing changes.

The goal is to improve code readability and maintainability.

@jmacdonald
Copy link
Owner

Hi @hamirmahal! Thanks for this; I wasn't aware Rust had made this combined syntax possible. I've made a bunch of changes to Amp's open mode, which has caused conflicts with your branch. If you can resolve those, I'll happily merge this in.

Thanks! 🍻

@hamirmahal
Copy link
Contributor Author

You're welcome! I'll take a look right now.

@hamirmahal hamirmahal force-pushed the style/simplify-string-formatting-for-readability branch from 77c764d to 1d4528b Compare October 26, 2024 16:31
@jmacdonald jmacdonald merged commit ebbeeba into jmacdonald:main Oct 26, 2024
1 check passed
@hamirmahal hamirmahal deleted the style/simplify-string-formatting-for-readability branch October 26, 2024 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants