Fix promise require call to work with npm@3 #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
updated 'npm test' command to replace the --harmony-generators flag with --harmony, since the former is no longer valid as of node v4
|
Apologies it took me so long to get this sorted, it's been updated now though and continues to work with npm@3 and npm@2 (also tested across node v0.12 and v4). I also had to update the npm test command to run with node v4 (replacing the --harmony-generators flag which is no longer valid), though I can remove that addition if that's not something you want getting bundled into this PR. |
|
+1 |
|
Can we get this merged in now? |
|
+1 Would like this to be merged in, as it forces me to use the fork in the meantime. |
jmar777
added a commit
that referenced
this pull request
Nov 6, 2015
Fix promise require call to work with npm@3
|
@jon-hall sorry for the long delay in getting back to this, but it's now merged and published to NPM as v0.7.0. Thanks so much! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #27