-
-
Notifications
You must be signed in to change notification settings - Fork 139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dev/test setup/notes needed #423
Comments
There are a few scattered https://github.com/jmathai/elodie/blob/master/requirements.txt Wonder if that can be handled by run_tests.py. This recommends calling out to pip - was hoping for something a bit nicer ... but doable - https://stackoverflow.com/a/50255019. |
Thanks @jmathai PR posted. NOTE the last requirements file does NOT work for Python 2.7:
I've been looking at different Python versions :-) If PR is good then this can be closed (py2.7 support would be a different/new issue). |
I strongly advise against auto pip installing in the test, offering a warning/exit/skip would be significantly safer and less surprising approach. |
Agree on auto installing without user confirmation. Did you submit a PR? |
I may have missed a step :-) posted/linked now |
It looks like dev testing needs additional libs, I've not got a successful run so not opened a PR.
Idea; add a new requirements file for dev. I think the contents needed is:
The text was updated successfully, but these errors were encountered: