Fix Flask 2x Support #233
Merged
Fix Flask 2x Support #233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using Flask 2x the send_static_file function is a lambda and crashes the extraction of the rules_by_endpoint function. There is currently a PR that has a fix but it's been stale so I'm adding this as a possible alternate fix. The other fix is: jmcarp#230
|
@sloria it looks like you also might be a maintainer of this repo. |
|
sorry for the delay; i'm not super active on this project. i'll merge and release this when i have some time off the clock. |
|
No worries, thank you! |
jollysahil
pushed a commit
to levrofin/flask-apispec
that referenced
this pull request
Sep 12, 2023
* Skip static rules When using Flask 2x the send_static_file function is a lambda and crashes the extraction of the rules_by_endpoint function. There is currently a PR that has a fix but it's been stale so I'm adding this as a possible alternate fix. The other fix is: jmcarp#230 * Update changelog Co-authored-by: Steven Loria <sloria1@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using Flask 2x the send_static_file function is a lambda and
crashes the extraction of the rules_by_endpoint function. There is
currently a PR that has a fix but it's been stale so I'm adding this as
a possible alternate fix.
The other fix is: #230
Closes #229
Note the unit tests were failing before this PR, they are now working again.
If anyone wants to use this version while we wait to have it merged and released I was able to add the following to my setup.py: