fixed oauth in mopidy ytmusic setup command
#4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also removed the upper boundary of pytube version because it collides with 15.0.0 and there are no changes preventing the current code from working.
|
Thanks for the PR. Haven't used the package in a bit, but glad to see there's still a community around it |
|
Thanks @jmcdo29. When you get a chance would you be able to create a new release? I'll update the arch package to pull from the release when it's ready. |
|
@kmac all right, new release has been made |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current version of this plugin (with your changes) doesn't work for creating a brand new
auth.jsonfile - the call forYTMusic(filepath)isn't correct anymore - thus, any new user would have issues. This change fixes that issue andmopidy ytmusic setuporsudo mopidyctl ytmusic setupwork fine again creating a correct file. I changed the default name of the file tooauth.jsonto prevent overwriting of the old auth file for people who still have and use it.Also removed the upper boundary of
pytubeversion because it collides with current version15.0.0and there are no changes preventing the code from working as is.