Add back support for order comparisons against strings #126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The validation added in 0.9.1 to make this compliant with the spec actually broke a number of people. I've added this back and will work on getting the spec updated. Fixes jmespath#124.
Codecov Report
@@ Coverage Diff @@
## develop #126 +/- ##
===========================================
+ Coverage 97.26% 97.27% +0.01%
===========================================
Files 13 13
Lines 1425 1431 +6
===========================================
+ Hits 1386 1392 +6
Misses 39 39
Continue to review full report at Codecov.
|
johnallen3d
added a commit
to telus-agcg-archive/jmespath.rb
that referenced
this pull request
Apr 9, 2020
This library currently only supports "comparison" of numberic values. This appears to match the JMESPath spec but is not consistent with other implementations (for example: [`jmespath.py`](jmespath/jmespath.py#126)). Resolves: jmespath#47
johnallen3d
added a commit
to telus-agcg-archive/jmespath.rb
that referenced
this pull request
Jan 31, 2022
This library currently only supports "comparison" of numberic values. This appears to match the JMESPath spec but is not consistent with other implementations (for example: [`jmespath.py`](jmespath/jmespath.py#126)). Resolves: jmespath#47
johnallen3d
added a commit
to telus-agcg-archive/jmespath.rb
that referenced
this pull request
Jan 31, 2022
This library currently only supports "comparison" of numberic values. This appears to match the JMESPath spec but is not consistent with other implementations (for example: [`jmespath.py`](jmespath/jmespath.py#126)). Resolves: jmespath#47
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The validation added in 0.9.1 to make this compliant with the
spec actually broke a number of people. I've added this back
and will work on getting the spec updated.
Fixes #124.