Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

generate a unittest for the new logging functionality #11

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

jmfranck
Copy link
Collaborator

No description provided.

@jmfranck jmfranck requested a review from guinneak198 May 28, 2020 15:54
Copy link
Contributor

@guinneak198 guinneak198 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So I'm assuming based on whatever file we would need to define the string that the working code outputs and then test that against the string the new code outputs. Does this only work for strings? can we compare ndshapes or nddata? However, over all I get the gist of what is being done

@jmfranck
Copy link
Collaborator Author

jmfranck commented Jun 6, 2020

I'm replying to your comment above, but there's no reply button.

In general, you there are tests where you can check the value of arrays, etc (I think I posted the code from the guy in Songi's lab -- Yanxian -- which does that)

However, here, we are actually interested in testing what the script prints out since I'm trying to test the logger. As it turns out, that's actually more complicated than the usual case, b/c you have the capture the output, etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants