-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
generate a unittest for the new logging functionality #11
base: master
Are you sure you want to change the base?
Conversation
this works equally as well as before, but there are still some problems
this is actually a super complicated example of a unittest, since I'm capturing the standard output (other unittests should be much simpler)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So I'm assuming based on whatever file we would need to define the string that the working code outputs and then test that against the string the new code outputs. Does this only work for strings? can we compare ndshapes or nddata? However, over all I get the gist of what is being done
I'm replying to your comment above, but there's no reply button. In general, you there are tests where you can check the value of arrays, etc (I think I posted the code from the guy in Songi's lab -- Yanxian -- which does that) However, here, we are actually interested in testing what the script prints out since I'm trying to test the logger. As it turns out, that's actually more complicated than the usual case, b/c you have the capture the output, etc. |
No description provided.