Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version 0.5.4 is a breaking change. It should be yanked and republished as 0.6 #19

Closed
demurgos opened this issue May 3, 2024 · 2 comments

Comments

@demurgos
Copy link

demurgos commented May 3, 2024

The release 0.5.4 includes changes from #17 where the requirement for http was changed from ^0.2.6 to ^1.0.0.

These are breaking changes because http is a public dependency (its types are leaking into the types defined by rustify) so applying a major semver requirement change on http propagates to rustify.

As an example, this now breaks vaultrs which currently depends on rustify: ^0.5.2 and http: ^0.2.9 and assumes unification between its http version and the one from rustify. See jmgilman/vaultrs#91

I recommend the following actions:

  • rustify 0.5.4 should be yanked immediately
  • rustify 0.6.0 should be released
  • Optional: All public dependencies should be re-exported at the lib root and consumers should avoid relying on implicit cargo version unification
@jmgilman
Copy link
Owner

jmgilman commented May 5, 2024

The package is yanked and pushed as 0.6.0.

@demurgos
Copy link
Author

demurgos commented May 5, 2024

Thanks, closing this issue then 🙂

@demurgos demurgos closed this as completed May 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants