Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump reqwest to 0.12 #17

Merged
merged 4 commits into from
Apr 3, 2024

Conversation

stormshield-gt
Copy link
Collaborator

Bump reqwest to 0.12 unlocking:

  • use of rustls 0.22
  • use hyper 1.0
  • use of http 1.0

@jmgilman I know you have been very busy lately, but could you please consider merging this.
This PR is very small (2 lines) and contains only trivial changes.

@jmgilman
Copy link
Owner

jmgilman commented Apr 3, 2024

Would you have the capacity to address CI? Won't help to merge if the build doesn't pass. I can maybe try to tackle it this weekend if you don't.

@stormshield-gt
Copy link
Collaborator Author

I'm on it, for clippy that's an upstream bug rust-lang/rust-clippy#12281 I will add some allow

@stormshield-gt
Copy link
Collaborator Author

The second issue is since dtolnay/trybuild#170 , trybuild fail if the .stderr files are not check-in,

The Ci should be fixed now 🎉

@jmgilman
Copy link
Owner

jmgilman commented Apr 3, 2024

Looks like the added files need a little adjusting.

@stormshield-gt
Copy link
Collaborator Author

Looks like the added files need a little adjusting.

It seems to be because the output of the compiler is different on stable and on nightly (used in CI).
David Tolnay advise testing only one toolchain in dtolnay/trybuild#84, so that's what I did.

@jmgilman
Copy link
Owner

jmgilman commented Apr 3, 2024

I see. Appreciate the help :) I'll merge and see if I can get a release pushed.

@jmgilman jmgilman merged commit 33d2aea into jmgilman:master Apr 3, 2024
5 checks passed
@stormshield-gt
Copy link
Collaborator Author

@jmgilman do you think you could find the time to cut out a new release?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants