-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for login via certificate #76
Conversation
Hey thanks for your pull request. It would be nice if you can add a test for the certificate login. I merged #62 can you rebase your branch then the checks should be able to pass. |
25a4313
to
f0ca351
Compare
f0ca351
to
13feb19
Compare
️✅ There are no secrets present in this pull request anymore.If these secrets were true positive and are still valid, we highly recommend you to revoke them. 🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request. |
I added two commits. I committed the keys and certificates as well as the method to generate them. I see that gitguardian is not happy about it even though those are just test certificates. I guess we could generate new certificates on every test run, provided we can run openssl in the runner. What do you think? |
Yes I think generating a new certificate each time would be the best solution for that. |
dfcf813
to
8d8e1d2
Compare
Done |
Hey tanks for implementing this. The test is failing at the moment because the nativ-tls feature didn't support pam only. It requires pkcs8 or pkcs12. |
I added a commit to disable the test with native-tls since vaultrs does not support client certificates with it anyway. See Line 298 in 34e3874
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With the suggestions we should get rid of the warnings.
1c839a2
to
6b5e4f4
Compare
Suggestions applied |
Thanks 👍 |
The first commit is cherry picked from #62
The second one is specific to this PR and allow one to use certificate to login to vault.